Bumpup cosmjs 0.30.1 - Githubissues

Finschia / finschia-js

finschia-js is javascript sdk for Finschia

Apache License 2.0

7 stars 4 forks source link

Bumpup cosmjs 0.30.1 #84

Closed loin3 closed 1 year ago

loin3 commented 1 year ago

In this PR, bumped cosmjs up to version 0.30.1. Additionally, there was a change in the eslint settings, so it was applied.

After this PR, please run yarn run lint-fix before upload PR.

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

[x] I have added a relevant changelog to CHANGELOG.md.
[x] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.

tkxkd0159 commented 1 year ago

nit: I think it's better to use original wasmTypes and just extend this with MsgInstantiate2Contract like below

[["/cosmwasm.wasm.v1.MsgInstantiate2Contract, MsgInstantiate2Contract"], ...wasmTypes]]

loin3 commented 1 year ago

Yes I wanted to use wasmTypes in cosmjs. but currently it is not exported correctly. that is why lbmjs has wasm module while every cosmwasm modules are separated from ours and we have our specific module wasmplus. I made an issue about this in cosmjs (https://github.com/cosmos/cosmjs/issues/1397). so lbmjs wasm module could be deleted in later version.