feat: update x/collection to use Finschia/cosmos-sdk - Githubissues

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk

Apache License 2.0

63 stars 30 forks source link

feat: update x/collection to use Finschia/cosmos-sdk #1208

Closed jaeseung-bae closed 7 months ago

jaeseung-bae commented 9 months ago

Description

closes: #1196

Remove useless features
- codec init (it's injected by cosmos/runtime now)
- msg's GetSigners(), Type(), Route(), GetSignBytes() -> sdk.Msg doesn't require those method anymore.
- remove FT features and its stored data
Migrate x/token's Class feature/data into x/collection module
Change some error codespace to maintain easily
- ErrInvalidPermission ( [link, 2] -> [collection, 101] )
- ErrInvalidContractID ( [contract, 2] -> [collection, 102] )
- ErrContractNotExist ( [contract, 3] -> [collection, 103] )
Apply v0.50.x to x/collection
- CLITestSuite verifies CLI processes before broadcasting.
- E2ETestSuite for gRPC, Tx

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

[ ] I followed the contributing guidelines and code of conduct.
[ ] I have added a relevant changelog to CHANGELOG.md
[x] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

sonarcloud[bot] commented 8 months ago

Quality Gate failed

Failed conditions
35.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

github-actions[bot] commented 7 months ago

@tkxkd0159 your pull request is missing a changelog!

jaeseung-bae commented 7 months ago

LGTM (Since this PR was requested by me, I can't click approve by myself)