Closed zemyblue closed 6 months ago
Attention: 41 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
feat/zkauth@1132e10
). Click here to learn what that means.
The hashed element for poseidon hash is written as Fr, but there are some that are already written as F (e.g. IssF), which can cause confusion. There are many things that already use F, so why not write it as F?
The hashed element for poseidon hash is written as Fr, but there are some that are already written as F (e.g. IssF), which can cause confusion. There are many things that already use F, so why not write it as F?
I use gnark style, but it's better to use f
. I'll modify it. Thank you.
Issues
0 New issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Description
Add
CalculateAllInputsHash
of ZKAuthInputs in x/zkauth moduleMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml