fix: stakingplus should implement AppmoduleSimulation to run TestAppStateDeterminism - Githubissues

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk

Apache License 2.0

63 stars 30 forks source link

fix: stakingplus should implement AppmoduleSimulation to run TestAppStateDeterminism #1265

Closed jaeseung-bae closed 6 months ago

jaeseung-bae commented 6 months ago

Description

stakingplus should implement AppModuleSimulation to run TestAppStateDeterminism
- Without AppModuleSimulation, make test-sim-nondeterminism is going to fail

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

[ ] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

ulbqb commented 6 months ago

~~make test-sim-nondeterminism~~ ~~How about add this test to CI?~~

By the way, the stakingplus module is going to be removed in #1271.

jaeseung-bae commented 6 months ago

~make test-sim-nondeterminism~ ~How about add this test to CI?~

By the way, the stakingplus module is going to be removed in #1271.

Yes, It'll be removed. I'll close this PR, because #1271 is under review.