Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: replace stakingplus module with staking hooks #1271

Closed ulbqb closed 6 months ago

ulbqb commented 6 months ago

Description

This PR replaces stakingplus module with staking hooks. It makes redundant files removed and maintenance easy.

This change has breaking change of proto.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

ulbqb commented 6 months ago

I have an issue. Should stakingplus proto file be modified? This PR makes modification to be minimal files. It's also possible to use proto file without modification. But if so, it contains redundant files.

tkxkd0159 commented 6 months ago

I have an issue. Should stakingplus proto file be modified? This PR makes modification to be minimal files. It's also possible to use proto file without modification. But if so, it contains redundant files.

I think current status looks not bad. And please add description about this PR(reason of deprecating stakingplus and new feature(hook) plus CHANGELOG