Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

feat: replaces decorators #1272

Closed shiki-tak closed 6 months ago

shiki-tak commented 6 months ago

Description

I made the following three fixes.

  1. Activate jwk fetch in simapp and zkauth MsgExecution can be executed.
  2. Replacement of the following decorators
    • IncrementSequenceDecorator
    • SetPubKeyDecorator
    • SigVerificationDecorator
  3. Other minor fixes

Note: Currently, the following antehandler must be commented out in order for simapp that includes the zkauth module to work properly. https://github.com/Finschia/finschia-sdk/pull/1272/files#diff-68f17637e76320504c315ee15128b4f711050394e820f1c4be80a2e8bdf52c43R43

Remaining

  1. Around fee DeductFeeDecorator SigGasConsumeDecorator

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 54.83871% with 56 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feat/zkauth@a2951cd). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## feat/zkauth #1272 +/- ## ============================================== Coverage ? 69.59% ============================================== Files ? 659 Lines ? 68274 Branches ? 0 ============================================== Hits ? 47514 Misses ? 18518 Partials ? 2242 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [simapp/ante/ante.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FudGUvYW50ZS5nbw==) | `67.85% <100.00%> (ø)` | | | [simapp/app.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FwcC5nbw==) | `82.82% <100.00%> (ø)` | | | [x/zkauth/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgva2VlcGVyL2tlZXBlci5nbw==) | `68.57% <100.00%> (ø)` | | | [x/zkauth/testutil/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdGVzdHV0aWwva2VlcGVyLmdv) | `53.60% <100.00%> (ø)` | | | [x/zkauth/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdHlwZXMvbXNncy5nbw==) | `32.89% <0.00%> (ø)` | | | [x/zkauth/ante/zkauth.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvYW50ZS96a2F1dGguZ28=) | `41.48% <33.33%> (ø)` | |