search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate #1274

Closed tkxkd0159 closed 5 months ago

tkxkd0159 commented 6 months ago

Description

closes: #XXXX

ref. https://github.com/cosmos/cosmos-sdk/pull/16554

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.74%. Comparing base (3e087f8) to head (0ff2753). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1274/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1274 +/- ## ========================================== - Coverage 69.74% 69.74% -0.01% ========================================== Files 643 643 Lines 67255 67258 +3 ========================================== + Hits 46906 46908 +2 - Misses 18176 18177 +1 Partials 2173 2173 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/auth/types/account.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL3R5cGVzL2FjY291bnQuZ28=) | `76.57% <100.00%> (+0.40%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1274/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)