Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

Ignore gas when zkauth #1275

Closed Mdaiki0730 closed 5 months ago

Mdaiki0730 commented 6 months ago

Description

zkauth uses a ephemeral key to perform tx signature and includes zkauth signature in msg.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 65.00000% with 21 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feat/zkauth@28cbf47). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## feat/zkauth #1275 +/- ## ============================================== Coverage ? 69.59% ============================================== Files ? 659 Lines ? 68322 Branches ? 0 ============================================== Hits ? 47548 Misses ? 18526 Partials ? 2248 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/zkauth/testutil/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdGVzdHV0aWwva2VlcGVyLmdv) | `55.38% <100.00%> (ø)` | | | [simapp/ante/ante.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FudGUvYW50ZS5nbw==) | `55.88% <33.33%> (ø)` | | | [x/zkauth/ante/zkauth.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvYW50ZS96a2F1dGguZ28=) | `51.14% <67.39%> (ø)` | |