Closed shiki-tak closed 7 months ago
Attention: Patch coverage is 36.36364%
with 7 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
feat/zkauth@7c1e68a
). Click here to learn what that means.
I didn't realize this at the time of design, but it seems that the appropriate field name is issBase64 instead of issF. Since it is related to this PR, how about fixing it all at once? https://github.com/Finschia/finschia-sdk/blob/feat/zkauth/proto/finschia/zkauth/v1beta1/zkauth.proto#L28
Would you write changelog?
Description
Modified to assume that iss used when calculating address is received as a base64 encoded value.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml