Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: correct set of address #1278

Closed shiki-tak closed 7 months ago

shiki-tak commented 7 months ago

Description

Modified to assume that iss used when calculating address is received as a base64 encoded value.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feat/zkauth@7c1e68a). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## feat/zkauth #1278 +/- ## ============================================== Coverage ? 69.58% ============================================== Files ? 659 Lines ? 68321 Branches ? 0 ============================================== Hits ? 47542 Misses ? 18530 Partials ? 2249 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/zkauth/types/zkauth\_inputs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdHlwZXMvemthdXRoX2lucHV0cy5nbw==) | `57.76% <66.66%> (ø)` | | | [x/zkauth/types/address.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdHlwZXMvYWRkcmVzcy5nbw==) | `57.14% <50.00%> (ø)` | | | [x/zkauth/ante/zkauth.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvYW50ZS96a2F1dGguZ28=) | `50.37% <0.00%> (ø)` | |
Mdaiki0730 commented 7 months ago

I didn't realize this at the time of design, but it seems that the appropriate field name is issBase64 instead of issF. Since it is related to this PR, how about fixing it all at once? https://github.com/Finschia/finschia-sdk/blob/feat/zkauth/proto/finschia/zkauth/v1beta1/zkauth.proto#L28

Mdaiki0730 commented 7 months ago

Would you write changelog?