Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

Deduct gas fee from zkauth address #1279

Closed Mdaiki0730 closed 5 months ago

Mdaiki0730 commented 5 months ago

Description

Deduct the gas fee that would have been deducted by DeductFeeDecorator from zkauth address Mostly the same as DeductFeeDecorator.AnteHandle. https://github.com/Finschia/finschia-sdk/blob/df06ee16ed85f660b391f69d0732d6b00560c5fa/x/auth/ante/fee.go#L75

In the future there should be a way to branch out with zkauth more generally.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 52.94118% with 24 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feat/zkauth@995ea48). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1279/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## feat/zkauth #1279 +/- ## ============================================== Coverage ? 69.56% ============================================== Files ? 659 Lines ? 68380 Branches ? 0 ============================================== Hits ? 47571 Misses ? 18554 Partials ? 2255 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1279?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/zkauth/testutil/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvdGVzdHV0aWwva2VlcGVyLmdv) | `55.38% <100.00%> (ø)` | | | [x/zkauth/ante/zkauth.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC96a2F1dGgvYW50ZS96a2F1dGguZ28=) | `50.00% <50.00%> (ø)` | |
Mdaiki0730 commented 5 months ago

So please add another issue for solving multiple messages.

I added an issue, so I'll merge this PR. Thank you. https://github.com/Finschia/finschia-sdk/issues/1286