Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport #1274) #1281

Closed mergify[bot] closed 7 months ago

mergify[bot] commented 7 months ago

Description

closes: #XXXX

ref. https://github.com/cosmos/cosmos-sdk/pull/16554

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 7 months ago

Cherry-pick of d9f1133a71d8de4bf0b26de132fe968d5a29b13c has failed:

On branch mergify/bp/release/v0.48.x/pr-1274
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit d9f1133a7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   x/auth/types/account.go
    modified:   x/auth/types/account_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.78%. Comparing base (cb6669c) to head (0c789a2).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1281/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1281 +/- ## ================================================ Coverage 69.78% 69.78% ================================================ Files 646 646 Lines 67495 67498 +3 ================================================ + Hits 47099 47103 +4 + Misses 18210 18209 -1 Partials 2186 2186 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1281?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/auth/types/account.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL3R5cGVzL2FjY291bnQuZ28=) | `76.57% <100.00%> (+0.40%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1281/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)