Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: add non-zero check of nextTokenID.Id for genesis (backport #1276) #1282

Closed mergify[bot] closed 5 months ago

mergify[bot] commented 5 months ago

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 5 months ago

Cherry-pick of 47a5e9fec430428b559a7c7ba7ec5e43774f7197 has failed:

On branch mergify/bp/release/v0.48.x/pr-1276
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 47a5e9fec.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   x/collection/genesis.go
    modified:   x/collection/genesis_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (6efd17d) to head (bdf2ba0).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1282/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1282 +/- ## =================================================== - Coverage 69.78% 69.78% -0.01% =================================================== Files 646 646 Lines 67503 67506 +3 =================================================== Hits 47108 47108 - Misses 18209 18212 +3 Partials 2186 2186 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1282?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/collection/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9jb2xsZWN0aW9uL2dlbmVzaXMuZ28=) | `91.51% <80.00%> (-1.70%)` | :arrow_down: |