search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: remove map iteration non-determinism with keys #1302

Closed tkxkd0159 closed 4 months ago

tkxkd0159 commented 4 months ago

Description

closes: #XXXX

ref. https://github.com/cosmos/cosmos-sdk/pull/13377

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.43%. Comparing base (e86b980) to head (f0e4562). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1302 +/- ## ======================================= Coverage 70.42% 70.43% ======================================= Files 643 643 Lines 54702 54720 +18 ======================================= + Hits 38526 38542 +16 - Misses 14006 14008 +2 Partials 2170 2170 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [baseapp/baseapp.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-YmFzZWFwcC9iYXNlYXBwLmdv) | `79.55% <100.00%> (+0.19%)` | :arrow_up: | | [store/rootmulti/store.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c3RvcmUvcm9vdG11bHRpL3N0b3JlLmdv) | `74.31% <100.00%> (+0.62%)` | :arrow_up: | | [types/module/module.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-dHlwZXMvbW9kdWxlL21vZHVsZS5nbw==) | `70.37% <66.66%> (-0.22%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1302/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)