Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: remove map iteration non-determinism with keys (backport #1302) #1305

Closed mergify[bot] closed 4 months ago

mergify[bot] commented 4 months ago

Description

closes: #XXXX

ref. https://github.com/cosmos/cosmos-sdk/pull/13377

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 4 months ago

Cherry-pick of c462f368628c092dafe48c254114143dbf596b35 has failed:

On branch mergify/bp/release/v0.48.x/pr-1302
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit c462f3686.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   baseapp/baseapp.go
    modified:   store/rootmulti/store.go
    modified:   types/module/module.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (1f8e902) to head (b384d08). Report is 1 commits behind head on release/v0.48.x.

:exclamation: Current head b384d08 differs from pull request most recent head b53b745. Consider uploading reports for the commit b53b745 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1305 +/- ## ================================================ Coverage 69.78% 69.78% ================================================ Files 646 646 Lines 67507 67526 +19 ================================================ + Hits 47109 47126 +17 - Misses 18212 18214 +2 Partials 2186 2186 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [baseapp/baseapp.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-YmFzZWFwcC9iYXNlYXBwLmdv) | `79.35% <100.00%> (+0.13%)` | :arrow_up: | | [store/rootmulti/store.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c3RvcmUvcm9vdG11bHRpL3N0b3JlLmdv) | `75.14% <100.00%> (+0.50%)` | :arrow_up: | | [types/module/module.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-dHlwZXMvbW9kdWxlL21vZHVsZS5nbw==) | `67.21% <66.66%> (-0.15%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1305/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)