Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (backport #1301) #1309

Closed mergify[bot] closed 4 months ago

mergify[bot] commented 4 months ago

Description

Cherry-pick of:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 4 months ago

Cherry-pick of 1038a394c9cbb7b21740b438cdda8b40b4db4c1a has failed:

On branch mergify/bp/release/v0.48.x/pr-1301
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 1038a394c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   x/staking/keeper/validator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (a496d32) to head (ff40409).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1309/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1309 +/- ## =================================================== - Coverage 69.78% 69.78% -0.01% =================================================== Files 646 646 Lines 67532 67541 +9 =================================================== + Hits 47130 47134 +4 - Misses 18215 18218 +3 - Partials 2187 2189 +2 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1309?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/staking/keeper/validator.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zdGFraW5nL2tlZXBlci92YWxpZGF0b3IuZ28=) | `81.09% <54.54%> (-1.17%)` | :arrow_down: |