Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
61 stars 31 forks source link

fix: replace IsEqual with Equal #1314

Closed ulbqb closed 8 months ago

ulbqb commented 8 months ago

Description

closes: #XXXX

cherry-pick: https://github.com/cosmos/cosmos-sdk/pull/14739

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.41%. Comparing base (05ff4ea) to head (7b7c491). Report is 1 commits behind head on main.

:exclamation: Current head 7b7c491 differs from pull request most recent head 5cebd5f. Consider uploading reports for the commit 5cebd5f to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1314 +/- ## ========================================== - Coverage 70.41% 70.41% -0.01% ========================================== Files 643 643 Lines 54758 54754 -4 ========================================== - Hits 38560 38555 -5 - Misses 14023 14025 +2 + Partials 2175 2174 -1 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [types/coin.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-dHlwZXMvY29pbi5nbw==) | `94.69% <100.00%> (-0.03%)` | :arrow_down: | | [x/auth/vesting/types/vesting\_account.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL3Zlc3RpbmcvdHlwZXMvdmVzdGluZ19hY2NvdW50Lmdv) | `86.82% <100.00%> (ø)` | | | [x/bank/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL2tlZXBlci9nZW5lc2lzLmdv) | `84.00% <100.00%> (ø)` | | | [x/bank/keeper/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL2tlZXBlci9pbnZhcmlhbnRzLmdv) | `61.53% <100.00%> (ø)` | | | [x/bank/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL3R5cGVzL21zZ3MuZ28=) | `97.50% <100.00%> (ø)` | | | [x/distribution/keeper/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9kaXN0cmlidXRpb24va2VlcGVyL2ludmFyaWFudHMuZ28=) | `54.63% <100.00%> (ø)` | | | [x/foundation/keeper/internal/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mb3VuZGF0aW9uL2tlZXBlci9pbnRlcm5hbC9pbnZhcmlhbnRzLmdv) | `100.00% <100.00%> (ø)` | | | [x/gov/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9nb3YvdHlwZXMvcGFyYW1zLmdv) | `7.05% <100.00%> (ø)` | | | [x/staking/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zdGFraW5nL2dlbmVzaXMuZ28=) | `58.86% <100.00%> (ø)` | | | [simapp/test\_helpers.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL3Rlc3RfaGVscGVycy5nbw==) | `10.37% <0.00%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1314/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
ulbqb commented 8 months ago

Can I ignore code cov failure? This is about deprecated function.

jaeseung-bae commented 8 months ago

Please put proper labels.