Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

fix: ignore error when key not found in keys delete (backport #1312) #1315

Closed mergify[bot] closed 6 months ago

mergify[bot] commented 6 months ago

Description

If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.

This pr cherry-pick the following pr:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 6 months ago

Cherry-pick of e5709f3324a4b766faa56fc51aed4a9d6b62d4c6 has failed:

On branch mergify/bp/release/v0.48.x/pr-1312
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit e5709f332.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   client/keys/delete.go
    modified:   client/keys/delete_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.78%. Comparing base (506f8ff) to head (506f8ff).

:exclamation: Current head 506f8ff differs from pull request most recent head 8ffc905. Consider uploading reports for the commit 8ffc905 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1315/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1315 +/- ## ================================================ Coverage 69.78% 69.78% ================================================ Files 646 646 Lines 67541 67541 ================================================ Hits 47134 47134 Misses 18218 18218 Partials 2189 2189 ```