Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
61 stars 31 forks source link

fix(crypto): error if incorrect ledger public key #1316

Closed jaeseung-bae closed 8 months ago

jaeseung-bae commented 8 months ago

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.41%. Comparing base (0176215) to head (d4e2c5b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1316/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1316 +/- ## ========================================== - Coverage 70.41% 70.41% -0.01% ========================================== Files 643 643 Lines 54746 54752 +6 ========================================== + Hits 38552 38555 +3 - Misses 14020 14022 +2 - Partials 2174 2175 +1 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1316?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [crypto/keyring/keyring.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y3J5cHRvL2tleXJpbmcva2V5cmluZy5nbw==) | `62.71% <50.00%> (+0.05%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)