Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: replace IsEqual with Equal (backport #1314) #1317

Closed mergify[bot] closed 4 months ago

mergify[bot] commented 4 months ago

Description

closes: #XXXX

cherry-pick: https://github.com/cosmos/cosmos-sdk/pull/14739

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 4 months ago

Cherry-pick of 143a763045dfea84c9d98fd09abfad188188ad08 has failed:

On branch mergify/bp/release/v0.48.x/pr-1314
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 143a76304.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   simapp/test_helpers.go
    modified:   types/coin.go
    modified:   types/coin_test.go
    modified:   types/dec_coin.go
    modified:   types/dec_coin_test.go
    modified:   x/auth/legacy/v043/store_test.go
    modified:   x/auth/vesting/types/vesting_account.go
    modified:   x/auth/vesting/types/vesting_account_test.go
    modified:   x/bank/keeper/genesis.go
    modified:   x/bank/keeper/grpc_query_test.go
    modified:   x/bank/keeper/invariants.go
    modified:   x/bank/keeper/querier_test.go
    modified:   x/bank/types/genesis.go
    modified:   x/bank/types/msgs.go
    modified:   x/distribution/keeper/delegation.go
    modified:   x/distribution/keeper/genesis.go
    modified:   x/distribution/keeper/invariants.go
    modified:   x/foundation/keeper/internal/invariants.go
    modified:   x/gov/abci_test.go
    modified:   x/gov/genesis.go
    modified:   x/gov/keeper/deposit_test.go
    modified:   x/gov/keeper/invariants.go
    modified:   x/gov/types/params.go
    modified:   x/mint/types/minter_test.go
    modified:   x/staking/genesis.go
    modified:   x/staking/types/msg_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (1f8e902) to head (9ec42c1). Report is 3 commits behind head on release/v0.48.x.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1317 +/- ## ================================================ Coverage 69.78% 69.78% ================================================ Files 646 646 Lines 67507 67522 +15 ================================================ + Hits 47109 47122 +13 - Misses 18212 18215 +3 + Partials 2186 2185 -1 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [types/coin.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=types%2Fcoin.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-dHlwZXMvY29pbi5nbw==) | `94.56% <100.00%> (-0.03%)` | :arrow_down: | | [x/auth/vesting/types/vesting\_account.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fauth%2Fvesting%2Ftypes%2Fvesting_account.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL3Zlc3RpbmcvdHlwZXMvdmVzdGluZ19hY2NvdW50Lmdv) | `87.18% <100.00%> (ø)` | | | [x/bank/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fbank%2Fkeeper%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL2tlZXBlci9nZW5lc2lzLmdv) | `86.66% <100.00%> (ø)` | | | [x/bank/keeper/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fbank%2Fkeeper%2Finvariants.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL2tlZXBlci9pbnZhcmlhbnRzLmdv) | `60.00% <100.00%> (ø)` | | | [x/bank/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fbank%2Ftypes%2Fmsgs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL3R5cGVzL21zZ3MuZ28=) | `98.01% <100.00%> (ø)` | | | [x/distribution/keeper/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fdistribution%2Fkeeper%2Finvariants.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9kaXN0cmlidXRpb24va2VlcGVyL2ludmFyaWFudHMuZ28=) | `54.46% <100.00%> (ø)` | | | [x/foundation/keeper/internal/invariants.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Ffoundation%2Fkeeper%2Finternal%2Finvariants.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mb3VuZGF0aW9uL2tlZXBlci9pbnRlcm5hbC9pbnZhcmlhbnRzLmdv) | `100.00% <100.00%> (ø)` | | | [x/gov/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fgov%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9nb3YvdHlwZXMvcGFyYW1zLmdv) | `5.94% <100.00%> (ø)` | | | [x/staking/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=x%2Fstaking%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zdGFraW5nL2dlbmVzaXMuZ28=) | `59.23% <100.00%> (ø)` | | | [simapp/test\_helpers.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree&filepath=simapp%2Ftest_helpers.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL3Rlc3RfaGVscGVycy5nbw==) | `9.96% <0.00%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1317/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)