mergify[bot]
commented
8 months ago Cherry-pick of c051dcc91d032648297656ebf3d9e00613d0aa58 has failed:
On branch mergify/bp/release/v0.48.x/pr-1319
Your branch is up to date with 'origin/release/v0.48.x'.
You are currently cherry-picking commit c051dcc91.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: x/auth/client/cli/tx_multisign.go
modified: x/auth/client/cli/tx_sign.go
modified: x/auth/client/testutil/suite.go
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: CHANGELOG.md
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
codecov[bot]
Description
closes: #XXXX
When signing an multisig tx, you are required to provide the multisig address (--multisig) and the key you are signing with (--from), but there's no check that the key is actually part of the multisig. This makes it very easy to accidentally sign with the wrong key and only figure it out when you try to broadcast the invalid tx that includes a signature from a key thats not in the multisig.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yamlThis is an automatic backport of pull request #1319 done by Mergify.