Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
61 stars 31 forks source link

fix: update param validation to fail on nil dec (backport #1323) #1325

Closed mergify[bot] closed 8 months ago

mergify[bot] commented 8 months ago

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

mergify[bot] commented 8 months ago

Cherry-pick of 55b6566bf3c0811a7e758dd166c980de343ad1f3 has failed:

On branch mergify/bp/release/v0.48.x/pr-1323
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 55b6566bf.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   x/mint/types/params.go
    modified:   x/slashing/types/params.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (69a3ec7) to head (696d83e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1325/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.48.x #1325 +/- ## =================================================== - Coverage 69.76% 69.74% -0.03% =================================================== Files 646 646 Lines 67573 67594 +21 =================================================== Hits 47142 47142 - Misses 18242 18263 +21 Partials 2189 2189 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1325?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/slashing/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1325?src=pr&el=tree&filepath=x%2Fslashing%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zbGFzaGluZy90eXBlcy9wYXJhbXMuZ28=) | `0.00% <0.00%> (ø)` | | | [x/mint/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1325?src=pr&el=tree&filepath=x%2Fmint%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9taW50L3R5cGVzL3BhcmFtcy5nbw==) | `6.47% <0.00%> (-0.62%)` | :arrow_down: |