Closed 170210 closed 2 months ago
Is it necessary to update CHANGLOG.md
Is it necessary to update CHANGLOG.md
I'm not sure. I think, It's okay to update changelog once when we launch this module to main branch.
Attention: Patch coverage is 14.10256%
with 67 lines
in your changes are missing coverage. Please review.
Project coverage is 70.30%. Comparing base (
55b6566
) to head (fea7a93
).
Please ignore codecov, this is just a initial template.
Should I remove this part. I think it should be init in genesis.go, because this is calculated by the current fnsa amounts. https://github.com/Finschia/finschia-sdk/blob/65b25b869458fdded81229ee43b42dcfc30bf083/proto/lbm/fswap/v1/params.proto#L13-L15
I heard that it is a constant value. Should we make a query for it? If it is needed, I think we can add it to the following query. https://github.com/Finschia/finschia-sdk/blob/4e0771a4be1e438ca31c2647976d2d6ed76f8b16/proto/lbm/fswap/v1/query.proto#L25-L29
Description
initialize fswap module
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml