search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

feat(x/fbridge): set target denom as module parameters #1366

Closed tkxkd0159 closed 4 months ago

tkxkd0159 commented 4 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 29.54545% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 69.50%. Comparing base (5e2cd7f) to head (be50a04). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1366 +/- ## ========================================== - Coverage 69.53% 69.50% -0.04% ========================================== Files 672 672 Lines 56111 56154 +43 ========================================== + Hits 39019 39029 +10 - Misses 14827 14858 +31 - Partials 2265 2267 +2 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [simapp/app.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=simapp%2Fapp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FwcC5nbw==) | `80.06% <100.00%> (ø)` | | | [x/fbridge/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9rZWVwZXIuZ28=) | `72.09% <100.00%> (-0.33%)` | :arrow_down: | | [x/fbridge/keeper/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9wYXJhbXMuZ28=) | `86.66% <100.00%> (+3.33%)` | :arrow_up: | | [x/fbridge/keeper/transfer.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Ftransfer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci90cmFuc2Zlci5nbw==) | `74.54% <100.00%> (ø)` | | | [x/fbridge/types/codec.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2NvZGVjLmdv) | `54.28% <50.00%> (-0.26%)` | :arrow_down: | | [x/fbridge/types/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2dlbmVzaXMuZ28=) | `0.00% <0.00%> (ø)` | | | [x/fbridge/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9nZW5lc2lzLmdv) | `8.47% <0.00%> (-1.88%)` | :arrow_down: | | [x/fbridge/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fmsgs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL21zZ3MuZ28=) | `0.00% <0.00%> (ø)` | | | [x/fbridge/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL3BhcmFtcy5nbw==) | `38.88% <0.00%> (-3.54%)` | :arrow_down: | | [x/fbridge/keeper/msg\_server.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9tc2dfc2VydmVyLmdv) | `0.00% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1366/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)