search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

Fix bug where amino is not supported in fswap and fbridge #1378

Closed zemyblue closed 1 month ago

zemyblue commented 2 months ago

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.58%. Comparing base (97570b2) to head (559fabd).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1378 +/- ## ========================================== + Coverage 69.50% 69.58% +0.08% ========================================== Files 668 668 Lines 56149 56208 +59 ========================================== + Hits 39025 39111 +86 + Misses 14857 14830 -27 Partials 2267 2267 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/fbridge/types/codec.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2NvZGVjLmdv) | `55.55% <100.00%> (+1.26%)` | :arrow_up: | | [x/fbridge/types/keys.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fkeys.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2tleXMuZ28=) | `0.00% <ø> (ø)` | | | [x/fbridge/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fmsgs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL21zZ3MuZ28=) | `66.66% <100.00%> (+66.66%)` | :arrow_up: | | [x/fswap/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378?src=pr&el=tree&filepath=x%2Ffswap%2Ftypes%2Fmsgs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mc3dhcC90eXBlcy9tc2dzLmdv) | `28.57% <85.71%> (+28.57%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1378/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)