Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

test: add validation & unit tests in fswap module #1382

Closed 170210 closed 4 months ago

170210 commented 4 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

170210 commented 4 months ago

Is it necessary to add the following validate in validateBasic:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.68%. Comparing base (92ad675) to head (1f01fc9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1382 +/- ## ========================================== + Coverage 69.58% 69.68% +0.10% ========================================== Files 668 668 Lines 56231 56242 +11 ========================================== + Hits 39126 39194 +68 + Misses 14834 14775 -59 - Partials 2271 2273 +2 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [simapp/app.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382?src=pr&el=tree&filepath=simapp%2Fapp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FwcC5nbw==) | `80.00% <100.00%> (ø)` | | | [x/fswap/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382?src=pr&el=tree&filepath=x%2Ffswap%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mc3dhcC9rZWVwZXIva2VlcGVyLmdv) | `60.16% <100.00%> (+9.30%)` | :arrow_up: | | [x/fswap/types/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382?src=pr&el=tree&filepath=x%2Ffswap%2Ftypes%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mc3dhcC90eXBlcy9nZW5lc2lzLmdv) | `81.25% <100.00%> (+53.25%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1382/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)