search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
61 stars 31 forks source link

fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) #1385

Closed jaeseung-bae closed 6 months ago

jaeseung-bae commented 6 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.57%. Comparing base (ed74ee8) to head (232b4ed). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1385/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1385 +/- ## ========================================== - Coverage 69.58% 69.57% -0.01% ========================================== Files 668 668 Lines 56208 56213 +5 ========================================== Hits 39111 39111 - Misses 14830 14833 +3 - Partials 2267 2269 +2 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1385?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/fswap/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1385?src=pr&el=tree&filepath=x%2Ffswap%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mc3dhcC9rZWVwZXIva2VlcGVyLmdv) | `50.86% <20.00%> (-0.68%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1385/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)