Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

chore: fix dummy denom coin data for test in fswap #1392

Closed 170210 closed 4 months ago

170210 commented 4 months ago

Description

The denomMetaData requires the Display field to appear in DenomUnits. This PR corrects the error dummy coin data in the test data.

https://github.com/Finschia/finschia-sdk/blob/main/x/bank/types/metadata.go#L73-L75

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.68%. Comparing base (e7c6501) to head (e5a25a1). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1392/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1392 +/- ## ========================================== + Coverage 69.57% 69.68% +0.11% ========================================== Files 668 668 Lines 56231 56242 +11 ========================================== + Hits 39125 39195 +70 + Misses 14835 14774 -61 - Partials 2271 2273 +2 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1392/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
jaeseung-bae commented 4 months ago

I think you should change PR title something starting with chore:. This PR corrects test data. Keeper runs bank's metadata validate logic when running SetSwap anyway.