build: add suffix string to docker container - Githubissues

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk

Apache License 2.0

62 stars 29 forks source link

build: add suffix string to docker container #1393

Closed jaeseung-bae closed 1 month ago

jaeseung-bae commented 1 month ago

Description

~refresh docker container's bound volume which refer to current working directory~
use current directory as a suffix for docker container to run it per their environment
- ~Without refreshing docker container with bound volume location,~ It doesn't generate proto, swagger depending on the current working directory
- For example
- Does work for ~/Finschia/fisnchia-sdk
- Doesn't work for ~/xxx/finschia-sdk
  - to work this, you should remove docker container first.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

[x] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

jaeseung-bae commented 1 month ago

Then, it should be deleted if the containerProtoGen already exist instead of starting.

Yes, It is. It should be deleted.

Or, we may just append the project name to the name of the container, which prevents the reuse by other projects.

Thanks for the comment, I'll try this one.