Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
61 stars 31 forks source link

fix: return error instead of panic for behaviors triggered by client (backport #1395) #1400

Closed mergify[bot] closed 6 months ago

mergify[bot] commented 6 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 69.37%. Comparing base (3e73dfe) to head (7775f10).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.49.x #1400 +/- ## ================================================ Coverage 69.37% 69.37% ================================================ Files 675 675 Lines 70052 70058 +6 ================================================ + Hits 48596 48603 +7 - Misses 19168 19169 +1 + Partials 2288 2286 -2 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/fbridge/keeper/transfer.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Ftransfer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci90cmFuc2Zlci5nbw==) | `78.46% <100.00%> (+6.58%)` | :arrow_up: | | [x/fbridge/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9nZW5lc2lzLmdv) | `8.57% <0.00%> (-0.26%)` | :arrow_down: | | [x/fbridge/keeper/auth.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fauth.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9hdXRoLmdv) | `55.64% <25.00%> (+0.37%)` | :arrow_up: | | [x/fbridge/keeper/abci.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1400?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fabci.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9hYmNpLmdv) | `0.00% <0.00%> (ø)` | |