search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

style: Improve code quality with new linters #1414

Closed tkxkd0159 closed 2 weeks ago

tkxkd0159 commented 3 weeks ago

Description

closes: #XXXX

New linter list

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 23.68421% with 58 lines in your changes missing coverage. Please review.

Project coverage is 69.63%. Comparing base (2ed0e6c) to head (7fcec2e). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1414 +/- ## ========================================== - Coverage 69.74% 69.63% -0.12% ========================================== Files 751 751 Lines 62259 62055 -204 ========================================== - Hits 43424 43210 -214 - Misses 16207 16214 +7 - Partials 2628 2631 +3 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [client/keys/show.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=client%2Fkeys%2Fshow.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y2xpZW50L2tleXMvc2hvdy5nbw==) | `81.65% <100.00%> (ø)` | | | [crypto/armor.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=crypto%2Farmor.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y3J5cHRvL2FybW9yLmdv) | `87.35% <100.00%> (ø)` | | | [crypto/keys/multisig/codec.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=crypto%2Fkeys%2Fmultisig%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y3J5cHRvL2tleXMvbXVsdGlzaWcvY29kZWMuZ28=) | `100.00% <ø> (ø)` | | | [snapshots/chunk.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=snapshots%2Fchunk.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c25hcHNob3RzL2NodW5rLmdv) | `88.23% <100.00%> (ø)` | | | [x/auth/ante/sigverify.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fauth%2Fante%2Fsigverify.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL2FudGUvc2lndmVyaWZ5Lmdv) | `70.60% <100.00%> (ø)` | | | [x/auth/vesting/client/testutil/suite.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fauth%2Fvesting%2Fclient%2Ftestutil%2Fsuite.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoL3Zlc3RpbmcvY2xpZW50L3Rlc3R1dGlsL3N1aXRlLmdv) | `100.00% <ø> (ø)` | | | [x/authz/client/testutil/grpc.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fauthz%2Fclient%2Ftestutil%2Fgrpc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoei9jbGllbnQvdGVzdHV0aWwvZ3JwYy5nbw==) | `97.27% <ø> (-0.05%)` | :arrow_down: | | [x/authz/client/testutil/query.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fauthz%2Fclient%2Ftestutil%2Fquery.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoei9jbGllbnQvdGVzdHV0aWwvcXVlcnkuZ28=) | `100.00% <ø> (ø)` | | | [x/authz/client/testutil/tx.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fauthz%2Fclient%2Ftestutil%2Ftx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9hdXRoei9jbGllbnQvdGVzdHV0aWwvdHguZ28=) | `97.87% <ø> (-0.02%)` | :arrow_down: | | [x/bank/client/testutil/grpc.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree&filepath=x%2Fbank%2Fclient%2Ftestutil%2Fgrpc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9iYW5rL2NsaWVudC90ZXN0dXRpbC9ncnBjLmdv) | `100.00% <ø> (ø)` | | | ... and [58 more](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1414/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)