Make x/wasm's API costs and event gas costs into parameters - Githubissues

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk

Apache License 2.0

63 stars 30 forks source link

Make x/wasm's API costs and event gas costs into parameters #414

Closed loloicci closed 1 year ago

loloicci commented 2 years ago

Summary

API costs of x/wasm are const now. And, event gas costs are stored in keeper. Make them into parameters.

Problem Definition

https://github.com/line/lbm-sdk/blob/dba5a4553fcf128f11abe5fcb7d9a551915c1e82/x/wasm/keeper/api.go#L15 and https://github.com/line/lbm-sdk/blob/dba5a4553fcf128f11abe5fcb7d9a551915c1e82/x/wasm/keeper/api.go#L26 define API costs (5 and 4). In the original wasmd, these are made into options https://github.com/CosmWasm/wasmd/pull/533. Other values than API costs that are made into options are already parameters in our x/wasm module.

And, event gas costs are defined in https://github.com/CosmWasm/wasmd/pull/539.

Proposal

Make API costs into parameters.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

170210 commented 1 year ago

This issue has been resolved in x/wasm/keeper/api.go