Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

Remove duplicated cosmos proto files. #877

Closed zemyblue closed 1 year ago

zemyblue commented 1 year ago

Summary

Remove duplicated cosmos proto files and change custom proto service to lbm proto.

Problem Definition

If other library import lbm-sdk and cosmos-sdk, a duplicate proto type registered warning is occurred like below. It can generate many problems. So we need to remove cosmos-sdk proto file and custom proto struct and service need to change lbm proto.

@mHXCV6H67LX build % ./wasmplusd version
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.crypto.multisig.v1beta1.MultiSignature
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.crypto.multisig.v1beta1.CompactBitArray
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.kv.v1beta1.Pairs
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.kv.v1beta1.Pair
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.snapshots.v1beta1.Snapshot
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.snapshots.v1beta1.Metadata
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.CommitInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.StoreInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.CommitID
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.store.v1beta1.StoreKVPair
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.TxResponse
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.ABCIMessageLog
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.StringEvent
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.Attribute
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.GasInfo
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.Result
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.SimulationResponse
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.MsgData
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.TxMsgData
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.abci.v1beta1.SearchTxsResult
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.Coin
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.DecCoin
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.IntProto
2023/02/02 18:12:53 proto: duplicate proto type registered: cosmos.base.v1beta1.DecProto

Proposal


For Admin Use

170210 commented 1 year ago

It was resolved by Finschia/wasmd#7