Finschia / flutter-bird

A decentralized Flappy Bird clone making use of NFTs.
MIT License
0 stars 1 forks source link

Support Mini Wallet #23

Closed ulbqb closed 3 months ago

ulbqb commented 3 months ago

This PR contains the following changes:

github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-23--flutter-bird.netlify.app

ulbqb commented 3 months ago

Demo on Mini Wallet browser:

https://github.com/user-attachments/assets/18ecec3d-0b2a-4ec2-8f7e-223a74737784

shiki-tak commented 3 months ago

I thought the purpose of this PoC was to create a dapp using LIFF, but is the LIFF flag unnecessary? After this, we can proceed with the task of checking what can be done using the LIFF API for additional research, etc.

ulbqb commented 3 months ago

@shiki-tak I think this project doesn't use LIFF feature despite of importing LIFF package. And we found that it's not needed to use LIFF in dApps.

shiki-tak commented 3 months ago

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

ulbqb commented 3 months ago

@shiki-tak

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

QR is needed if it's in PC but it's not easy to distinguish if it's PC browser view or mobile browser view.

shiki-tak commented 3 months ago

@shiki-tak

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

QR is needed if it's in PC but it's not easy to distinguish if it's PC browser view or mobile browser view.

@ulbqb This is the code I committed last week. Is it possible to do this using this? https://github.com/shiki-tak/flutter-bird/commit/a11da6f12e1c585875f55557a5577e8c62d47006

ulbqb commented 3 months ago

@shiki-tak Thank you. I'll try it.