Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.
MIT License
155 stars 115 forks source link

Duplicated categories tabs #12

Closed EsteveAguilera closed 2 years ago

EsteveAguilera commented 3 years ago

Using version emoji_picker_flutter: ^1.0.4 I've got duplicated categories tabs.

image

I've not been able to reproduce it a second time ๐Ÿคท

Fintasys commented 3 years ago

@EsteveAguilera Thanks for reporting this issue ! First time I hear about this issue, please let me know if it happens again. I will check if can find something.

rocboronat commented 3 years ago

Yey! Just happened to mee too. We're working together on the same app, hehe... It happened when pushing a new screen on the one that shows the emoji, and then pop it. When rebuilding the tree, the keyboard shown the categories duplicated.

Maybe there's a race condition?

Fintasys commented 3 years ago

Good to have a way to replicate bugs, thanks for sharing. You both are keeping me busy ๐Ÿคฃ Feel free to investigate into the issues as well, I'm currently lacking a bit of time. ๐Ÿ™

Fintasys commented 3 years ago

I've tried to reproduce again because it also happened to me in the past when I did hot reload. But also with the steps above I couldn't reproduce it in current version. I doubt that it is gone but I will keep an eye on it

rocboronat commented 3 years ago

Oh! ๐Ÿ˜ฒ

Maybe it happened because of the hot reload! If you want to, close the issue. If it happens again on the production app we will share it again so you can reopen the issue. Hope it never happens again! ๐Ÿ˜„

Thanks for your time, @Fintasys ๐Ÿ˜Š

rocboronat commented 2 years ago

Some months later I didn't see it happening again... So I close the issue. If it happens again, I'll reopen it or open a new one. Thanks for the support! ๐Ÿ™‡

rocboronat commented 2 years ago

Oh, I don't have permissions to close issues, haha!

rocboronat commented 2 years ago

Hey! It happened on release mode. And after closing the keyboard and opening it again, it was fixed :ยท/ Weird. @Fintasys may you reopen the issue?

Fintasys commented 2 years ago

@rocboronat even in release mode? That's not good ๐Ÿ˜… I would appreciate help, otherwise I will look into the issue when I find time ๐Ÿ™‡

rocboronat commented 2 years ago

Zeeero hurries, of course! It's not something that happens a lot. I will take a look into it if I have time. Maybe after we released our new Flutter app! ๐Ÿš€

Thanks a lot for your time ๐Ÿ˜„

rocboronat commented 2 years ago

It happened again! It's so weird it doesn't duplicate the first two tabs, as @EsteveAguilera shows in his screenshot.

Fintasys commented 2 years ago

@rocboronat I've fixed some bugs and enable hot reload support for this library. Hopefully rebuilding the Widget completely when the state is dirty should fix this issue ๐Ÿ™

rocboronat commented 2 years ago

Ooooh thanks! If you want us to test it on producton as brave people do, count with us ๐Ÿ˜„

Fintasys commented 2 years ago

@rocboronat I'll leave that up to you ๐Ÿ˜† I gonna release the changes soon on pub.dev if there aren't any issues reported in dev. But I'm curious about your App if it's already public, would love to see my picker in a production App ๐Ÿ˜„

rocboronat commented 2 years ago

It's not public yet... you'll be the first one to know it when we release it! It the meantime, it's called QuitNow. We're replacing the published one, a native Android, with a Flutter one ๐Ÿ˜Š

Fintasys commented 2 years ago

Awesome ! Gotta wait and start smoking beforehand to have an actual use case ๐Ÿ˜†

rocboronat commented 2 years ago

Hahaha! That's braver than testing on production! ๐Ÿ˜‚

rocboronat commented 2 years ago

We're almost on production! Buuut the latest version of the app also has the issue. In a different way, though! It's funny :ยท)

photo_2021-09-06_13-50-34

Fintasys commented 2 years ago

@rocboronat Argh, limited funny ๐Ÿ˜„ But at least now it repeats the whole category list and not every category icon twice. Might be a hint to locate the problem

Fintasys commented 2 years ago

@EsteveAguilera @rocboronat Could you take a quick look at this PR? I tried again to address this issue and would like to hear your opinion. Thank you!

verhneudinec commented 1 year ago

Hi, @Fintasys! Duplication remains. It is reproduced during a clean installation of the release or profile build of the application (Flutter 3.3.0) :(

Temporarily, passing a key (UniqueKey) to EmojiPicker may help.