fix(android): build.gradle namespace

Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.

MIT License

170 stars 127 forks source link

fix(android): build.gradle namespace #149

Closed jonasbadstuebner closed 1 year ago

jonasbadstuebner commented 1 year ago

Make it conditional, because it could break the build on Gradle < 8.0

Fintasys commented 1 year ago

@DrBu7cher Is that issue and solution documented somewhere?

cnkygmr commented 1 year ago

A problem occurred configuring project ':emoji_picker_flutter'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

luis901101 commented 1 year ago

@DrBu7cher Is that issue and solution documented somewhere?

The problem being fixed by this PR is related to AGP > 8, and the solution here is compatible with older versions of AGP so the plugin will be compatible with any AGP version from >= 4.2

check here: https://github.com/flutter/flutter/issues/125621#issuecomment-1525995461