Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.
MIT License
154 stars 114 forks source link

iOS lag issue with Google Fonts #185

Closed Fintasys closed 5 months ago

Fintasys commented 5 months ago

I've noticed a weird lag on iOS when I was developing for version 2.0. Unfortunately this issue already exists in current version 1.6.3 and seems to be related with GoogleFonts. When I remove GoogleFonts it works perfectly fine. I tried to improve the Google Fonts setup, making sure the font is loaded before the EmojiPicker is displayed, but I couldn't resolve the issue πŸ€” I could only test it on simulator for now and not physical device. Hopefully the issue exists only on my computer πŸ™

Reproducible using main_custom_font.dart example. or current version 2.0 WhatsApp example

Video:

https://github.com/Fintasys/emoji_picker_flutter/assets/11667234/633b6fb8-cc0c-4f56-82b2-31b668380e6a

Fintasys commented 5 months ago

@emesterhazy @LostInDarkMath @yendacoder You guys contributed a lot in the past, If you have time, I would appreciate if you could check if the issue is reproducible and what could cause it. πŸ™‡

LostInDarkMath commented 5 months ago

Hi @Fintasys unfortunately I cannot test this because I do not have any Apple device.

yendacoder commented 5 months ago

Hi @Fintasys It is reproducible on simulator, but on a device it's not bad at all. In debug mode there's a tiny lag, way less than on emulator. In release mode it's perfectly fine, as for me, so I wouldn't bother spending too much time on this. Maybe someone wants to check the performance trace out of curiosity, but my iOS setup is too cumbersome for this.

https://github.com/Fintasys/emoji_picker_flutter/assets/91149096/3c971ef6-aa89-4452-a790-79e227e7ed56

Fintasys commented 5 months ago

@yendacoder thank you, I appreciate your quick help to check the issue! That's really relieving πŸ™In a few days I have access again to a physical device and will double check it πŸ‘

Fintasys commented 5 months ago

Issue seems not exist in release mode or physical device.