search

Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.
MIT License
164 stars 125 forks source link

[Feature] Add EmojiPickerUtils for advanced usage #38

Closed zhourengui closed 2 years ago

zhourengui commented 2 years ago

close: #37

I encountered a need to search for emojis feature, but I can’t get all emojis, so I think a public method class should be implement for the convenience of expansion.

I think this change should be very useful, for example:

  1. when our package adds a category, we don’t need to modify it in multiple places
  2. want to expand the function of searching emoticons, at this time, we need to get all the expressions, this method does not require the user to reassemble all the expression data.
Fintasys commented 2 years ago

Overall I understand what you want to achieve and it does sounds good to me. Beside my comments above I think it would be great if you could also adjust the readme for this change and explain how it can be used.

zhourengui commented 2 years ago

Overall I understand what you want to achieve and it does sounds good to me. Beside my comments above I think it would be great if you could also adjust the readme for this change and explain how it can be used.

I have modified it, thank you very much for your feedback.

zhourengui commented 2 years ago

I added the addEmojiToRecentlyUsedfang method, because it should be useful when expanding

zhourengui commented 2 years ago

Your point of view is very correct. I didn’t consider the compatibility issue at the beginning. The method I’m exposing now is to get all the available category emoji and all the available emoji entities and search emoticons.

zhourengui commented 2 years ago

I have already changed it, I believe this is the best version, and I have tested it locally with version 2.0.1 of flutter, and I have not found any problems for the time being. thank you very much for the feedback these days.😃

zhourengui commented 2 years ago

The default value of the recentsLimit parameter of the addEmojiToRecentlyUsed method should be changed to 28. If I don't need to modify the others, please help me change it.

zhourengui commented 2 years ago

It has been revised, although the process is very difficult, but the ending is good.😃

zhourengui commented 2 years ago

@zhourengui Sorry for the delay I was busy. Thank you for your hard work, I think it's good to go now. I will improve the documentation as you mentioned in another PR to make it easier for me. Also I have some other changes related to the emoji's that I want to do first before releasing it as a new version, so please be patient a bit more. You can use the master directly in your app if you need the changes asap.

It's okay, don't worry, I'm currently using a temporary tool class in my project to solve the problem, and when everything is done, I'm going to upgrade.