search

Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.
MIT License
164 stars 125 forks source link

Added const keyword and background container to loading indicator #62

Closed LostInDarkMath closed 2 years ago

LostInDarkMath commented 2 years ago

Hi @Fintasys, I added a const keyword to the EmojiPicker and a Container to the CircularLoadingIndicator. The reason for this is I use the EmojiPickerWidget sometimes with a transparent background. After evaluate every option I came to the conclusion that the best solution for this is to modify your library and add the Container.

I also tried to run your example and I had some issues. Therefore, I do some modifications the build.gradle files to make it work.

Let me know if you agree with my changes :)

Fintasys commented 2 years ago

@LostInDarkMath Sorry for the late response. Can you rebase your branch and include only the necessary changes and avoid changes in pubspec.lock? Otherwise looks good to me, thank you!

LostInDarkMath commented 2 years ago

@Fintasys Done :)

LostInDarkMath commented 2 years ago

I also improve your README.md a bit ;)

Fintasys commented 2 years ago

Sorry that it took me so long! Great work, thank you so much!