FinucaneLab / fine-mapping-inf

Fine-mapping with infinitesimal effects
14 stars 3 forks source link

FINEMAPinf resulting in more SNPs with PIP > 0.9 than regular FINEMAP? #11

Closed gunns2 closed 7 months ago

gunns2 commented 7 months ago

Hello,

I am running both SuSiE-inf and FINEMAP-inf in addition to regular SuSiE and FINEMAP and finding that FINEMAP-inf is resulting in far more variants with high PIP than the other methods. This is surprising given the results in the FINEMAPinf/SuSiEinf paper. Do you have any idea why this may be happening? SuSiE-inf seems to be behaving fine and there are no errors in the log files.

I am also right now treating a binary trait as continuous. Could this be the issue?

thanks so much!

Sophie

cuiran commented 7 months ago

Hi Sophie,

Are you using in-sample LD or reference LD? I find FINEMAP-inf to be much more susceptible to LD mismatch than the other methods. There are other complications that comes with using reference panel LD. We didn't address this in the paper because both inf methods are developed for the use of single-cohort fine-mapping with in-sample LD. But I am aware that sometimes people use these methods with reference panel LD, and sometimes with meta-analyzed GWAS. I'd recommend caution in this case. If this is your use case, I recommend checking out the fine-mapping methods that are developed with this in mind, like SLALOM or CARMA.

gunns2 commented 7 months ago

Hello,

Thank you so much for the prompt response! I think this is probably the issue. We were already planning on implementing SLALOM but I will check out CARMA.

Thanks again!