search

Fiona-J-W / NiceCharts

An Inkscape-extension to draw charts
GNU General Public License v3.0
24 stars 10 forks source link

Some more features #4

Closed ghost closed 8 years ago

ghost commented 11 years ago

Hi,

I added some code to display data values above/right of bar charts. I also fixed an issue with repeating keys if there are more than 8 values drawn.

Maybe you want to check this out.

Regards,

Simon

Fiona-J-W commented 11 years ago

Thanks for improving the program. I like most of your changes, but sadly your change with the drop down-menue disables the possibility to enter custom color-schemes at runtime; if you have a good idea how to combine those two features, I'd definitely merge your changes.

ghost commented 11 years ago

Am 03/13/13 18:14, schrieb Florian Weber:

Thanks for improving the program. I like most of your changes, but sadly your change with the drop down-menue disables the possibility to enter custom color-schemes at runtime; if you have a good idea how to combine those two features, I'd definitely merge your changes.

— Reply to this email directly or view it on GitHub https://github.com/Florianjw/NiceCharts/pull/4#issuecomment-14855109.

Hi!

yes,you are right, the drop down menue only shows the defined schemes, no way to add color-schemes at runtime, but how would you do that anyway? If I understand this right, you must add a new colorscheme to nicechart_colors.py to make it available, either by choosing from a dropdown menu or by eintering the name in the text box. But on runtime (I understand this as inkscape is started and the Extension dialog is open) one can only use color schemes already defined in the nicechart_color.py files, so there's no way to add new schemes on runtime. or do i get this wrong?

I still favor the drop down menu,(but are cleary willing to revert to the text-box, if you want to) because then one can see and choose from all available color schemes, otherwise the user woudl have to look up the schemes in the nicechar_colros.py file to find out which are avail.

Please tell me what you think about this.

Regards, Simon

Fiona-J-W commented 11 years ago

If you enter for example “#ffff00, #000000” as color, then it will use those two colors as color-scheme(Though, when I look at it, it is correct that this work is done in different places and should both be brought together). It might be a reasonable solution to create a combined input to get both advantages.

Fiona-J-W commented 8 years ago

Sorry, I didn't see that you added that functionality back, and just came across this old project via a bugreport. The new version is certainly an improvement, so let's merge this thing.