search

FirEmerald / AdditionalPlacements

Vertical Slabs and Stairs framework and implementation
MIT License
6 stars 4 forks source link

shaders #46

Open HaterInViolet opened 1 year ago

HaterInViolet commented 1 year ago

When I turn on ANY shaders blocks turn into this: 2023-11-04_09 57 06

FirEmerald commented 1 year ago

Which minecraft version is this? Also, this might be an issue with the shader mod you are using, so please share. The models are no different from vanilla models with the one exception that they dynamically swap out the UV between sprites so what has happened here is almost certainly a modification to the storage of the UV coordinates in model data.

HaterInViolet commented 1 year ago

Version 1.20.1, optifine as base - complementary shader - euphoria patches as addition to shader, I tested it on seus's and vanilla plus and they all work the same. And please explain the last line cuz I don't understand anything

FirEmerald commented 1 year ago

essentially the vertex format defines where in the model's data UV coordinates are stored - if it's changed from the default, the mod can no longer properly adjust the UV coordinates to match the block's textures. The good news is, I have pushed an update to the source code that might fix this issue on forge 1.18.2 and newer, but it hasn't been built and uploaded to curse yet. In other news, I would recommend switching away from optifine altogether, as it's performance-heavy and known to cause issues with mods. you should be using rubidium and Oculus for forge, or Sodium and Iris for fabric.

HaterInViolet commented 1 year ago

at this point I don't think I'll be using this mod since I don't build a lot with slabs or stairs but it's always good to know that bugs like these exist and that they are fixed, still a very cool mod

FirEmerald commented 1 year ago

reopening because I don't actually have confirmation the issue is fixed.

ambientNexus commented 1 year ago

Version 1.20.1, optifine as base - complementary shader - euphoria patches as addition to shader, I tested it on seus's and vanilla plus and they all work the same. And please explain the last line cuz I don't understand anything

Have you tried swapping optifine out for Embeddium + Oculus? Optifine is notorious for breaking mods in newer versions, and patches to make other mods compatible with it are difficult due to its closed-source nature.

FirEmerald commented 1 year ago

I did already mention switching away from optifine. Honestly the mod really only gets used due to how popular it used to be - it's too heavyweight now and essentially all of its features exist in newer mods that are much, much more performance-friendly and less likely to cause issues with other mods.