FirEmerald / AdditionalPlacements

Vertical Slabs and Stairs framework and implementation
MIT License
4 stars 4 forks source link

[SUGGESTION] Mod compatibility with Quark and Mekanism #6

Closed Bazyliii closed 1 year ago

Bazyliii commented 2 years ago

If possible can you add compatibility for Mekanism additions and Quark slabs and stairs?

FirEmerald commented 2 years ago

Assuming those mods are using the vanilla SlabBlock and StairBlock there shouldn't be any compat to make.

FirEmerald commented 2 years ago

Well heck I forgot to update the 1.19 mod to not reject slabs with extra blockstate properties, will fix

FirEmerald commented 2 years ago

Alright, Mekanism is fixed with ba45bdbe3bfbd39d1725af794c62826e1d19b96d, quark doesn't work because they do some really weird and quite frankly WRONG registration work and I'm not going to attempt to make it work manually. That's on them, go open an issue in their github instead.

Bazyliii commented 2 years ago

Ok, sadly newest version of Create isn't working too can you take a look in that? Thx!

FirEmerald commented 2 years ago

I have identified the issue - mod events don't respect the event priority outside of the mod's own events, so even though the priority for the block registration event is LOWEST, it still runs before the NORMAL priority registration events of mods loaded after it.

FirEmerald commented 2 years ago

fixed as of 93b47f99f6076ae1d3571fefac37be7e1e926993 and 26640f4ee19a11cef90914973169029b228ae3d1

Bazyliii commented 2 years ago

I have found another bug with Mekanism compatibility. Transparent plastic's slabs and stairs when placed are just plain white, without any transparency. There maybe more incompatibilities with other mods that add transparent slabs and stairs. But I couldn't test it.

2022-09-29_16 33 33

FirEmerald commented 2 years ago

Most likely they aren't being properly set to the correct render types, I'll have to see what I did wrong there

FirEmerald commented 2 years ago

Is this in 1.18.2 or 1.19.2? it's important to know as 1.19.2 actually gets the render layer by the model.

Bazyliii commented 2 years ago

All bugs that I post are in 1.19.2 and always in newest version of mods :)

FirEmerald commented 1 year ago

Fixed as of d5d82a3424f64e35caf4b4b2d5552a110dad7442 and b9279289733a8874289ccbd51f5770fe94164fb9