search

FirEmerald / AdditionalPlacements

Vertical Slabs and Stairs framework and implementation
MIT License
6 stars 4 forks source link

Unknown Mod Incompatibility Crash [2.0.0, Forge 1.20.1] #93

Closed emihead closed 3 weeks ago

emihead commented 3 weeks ago

This issue may be invalid because I haven't tested the specific other mod that AP is having issues with, but 2.0.0 is crashing my modpack. Downgrading fixes the issue completely. If I had to guess, it may be Accessories or its Curios compat layer since that's what the logs suspect... but you never know. I'll try testing with just those two in a different instance.

Latest.log with 2.0.0: https://mclo.gs/fCnd3IV Latest.log with 1.8.0: https://mclo.gs/e29LkSK

emihead commented 3 weeks ago

Ok, I did some tests with some of the mods I saw mentioned in the crashlog and I got nothing. image Sorry for not testing more, I just have a lot of mods and not a lot of patience. Feel free to close this issue if it's invalid but maybe it's something obvious that I missed.

Dominus-Sicarum commented 3 weeks ago

Have similar problem, tested my modlist (Minecraft 1.20.1), the following mods each cause crash at startup:

Create: Copycats+ Hexerei

Confirmed on a fresh instance with no other mods except Additional Placements and Create, since it's needed for Copycats+, installed.

FirEmerald commented 3 weeks ago

these issues are unrelated

QianFuv commented 3 weeks ago

1.19.2 forge crash on my own modpack

FirEmerald commented 3 weeks ago

1.19.2 forge crash on my own modpack

  1. hijacking another person's issue
  2. not providing any useful information

wanna go for strike number 3?

emihead commented 3 weeks ago

Seems fixed in 2.0.1, no more crashing. Thanks!

FirEmerald commented 3 weeks ago

WTF the fix wasn't even related to this issue, or to rendering in general. All I did was change the location of the hook to dynamically create block variants.

emihead commented 3 weeks ago

I'm not even surprised lol, Minecraft is such an enigma sometimes

emihead commented 3 weeks ago

After checking things out ingame I realized the rendering is definitely a bit buggy in my pack, with sideways stairs kinda just... not working? My best guess is that it's just a side effect of this not being an intended fix, with the underlying problem still existing but causing rendering problems rather than crashing. image Considering the game at least runs, though, I'm honestly not too pressed about it since I can just turn on the old logic for stairs anyway.

QianFuv commented 3 weeks ago

1.19.2 forge crash on my own modpack

  1. hijacking another person's issue
  2. not providing any useful information

wanna go for strike number 3?

To be honest this issue happened so suddenly, I just wanted to quickly let the developers know that this issue also happens on 1.19.2forge, I have 600+ mods in my pack and I can't find the minimum test set by dichotomizing in a short time.

FirEmerald commented 3 weeks ago

1.19.2 forge crash on my own modpack

  1. hijacking another person's issue
  2. not providing any useful information

wanna go for strike number 3?

To be honest this issue happened so suddenly, I just wanted to quickly let the developers know that this issue also happens on 1.19.2forge, I have 600+ mods in my pack and I can't find the minimum test set by dichotomizing in a short time.

that's not an excuse for not providing a crashlog, and then posting on someone else's issue topic that might not even be the same issue. Not all crashes are the same.

FirEmerald commented 3 weeks ago

After checking things out ingame I realized the rendering is definitely a bit buggy in my pack, with sideways stairs kinda just... not working? My best guess is that it's just a side effect of this not being an intended fix, with the underlying problem still existing but causing rendering problems rather than crashing. image Considering the game at least runs, though, I'm honestly not too pressed about it since I can just turn on the old logic for stairs anyway.

that's made even more strange by the fact that I specifically added a command that generates a structure that shows every single possible blockstate a stair can have, to ensure the models and collision were all correct, which I then proceeded to check across EVERY SINGLE VERSION of the mod (13 of them!) to ensure it was correct.