FireAtWill275 / media_query

media query hw
0 stars 0 forks source link

Feedback on assignment 7 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #7 Project: Responsive Design


Description

Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.

Student: William Buckley

Project URL: https://github.com/FireAtWill275/media_query__

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use media queries at a 768px breakpoint x
Content remains in appropriate divs x
Content remains visible to the user x
Fonts change size appropriately x
Margins and padding change size appropriately x
Content does not overlap x
In the blog section, the two-column layout changes to a single-column layout when appropriate x
TOTAL: 11/14
barryross commented 7 years ago

Hey Will,

You are doing some great work here! The marks I left off are relatively easy things to address. The main thing is that I suggest making your img es width:100% and see how that affects the layout. That should help your contain remain visible. (attachment 1)

screen shot 2017-05-03 at 12 38 00 pm

The only other things are that I would suggest having some padding on the mobile version, and would suggest increasing the size of the post text (.post p), and decreasing the size of your headings (h1-h6) on mobile.

You may also want to consider centering the "categories, about etc." when stacked vertically (attachment 2)

screen shot 2017-05-03 at 12 37 53 pm