FireBurn / Overlay

Gentoo Overly
GNU General Public License v3.0
21 stars 6 forks source link

dev-libs/libclc-9999 fails configuring source with a SyntaxError #12

Closed jasnn closed 11 years ago

jasnn commented 11 years ago

After enabling the opencl and r600-llvm-config USE flags, my update world stops when attempting to emerge dev-libs/libclc-9999. I thought is may be because the syntax in line 42 of the ebuild should be changed from ;

--with-llvm-config="${EPREFIX}/usr/bin/llvm-config" \ to --with-llvm-config="${EPREFIX}"/usr/bin/llvm-config \

But I after I made the change and re-digested the ebuild, the emerge still fails with the same "SyntaxError". The short build log follows below.

Build log:
-----------
 * Package:    dev-libs/libclc-9999
 * Repository: FireBurn
 * Maintainer: x11@gentoo.org
 * USE:        abi_x86_64 amd64 consolekit elibc_glibc kernel_linux multilib policykit userland_GNU
 * FEATURES:   sandbox
>>> cfg-update-1.8.2-r1: Checksum index is up-to-date ...
>>> Unpacking source...
GIT update -->
   repository:               git://people.freedesktop.org/~tstellar/libclc
   at the commit:            bc1fb05f63e165cb4556b8d1f06c131a9719f98e
   branch:                   master
   storage directory:        "/usr/portage/distfiles/egit-src/libclc"
   checkout type:            bare repository
Cloning into '/tmp/portage/dev-libs/libclc-9999/work/libclc-9999'...
done.
Branch branch-master set up to track remote branch master from origin.
Switched to a new branch 'branch-master'
>>> Unpacked to /tmp/portage/dev-libs/libclc-9999/work/libclc-9999
>>> Source unpacked in /tmp/portage/dev-libs/libclc-9999/work
>>> Preparing source in /tmp/portage/dev-libs/libclc-9999/work/libclc-9999 ...
 * Applying fix-install-target.patch ...
 [ ok ]
 * Applying 0001-Rename-includes.patch ...
 [ ok ]
>>> Source prepared.
>>> Configuring source in /tmp/portage/dev-libs/libclc-9999/work/libclc-9999 ...
  File "./configure.py", line 63
    print "Error executing llvm-config."
                                       ^
SyntaxError: invalid syntax
>>> Source configured.
>>> Compiling source in /tmp/portage/dev-libs/libclc-9999/work/libclc-9999 ...
>>> Source compiled.
>>> Test phase [not enabled]: dev-libs/libclc-9999

>>> Install libclc-9999 into /tmp/portage/dev-libs/libclc-9999/image/ category dev-libs
make j1 DESTDIR=/tmp/portage/dev-libs/libclc-9999/image/ install 
make: *** No rule to make target `j1'.  Stop.
 * ERROR: dev-libs/libclc-9999 failed (install phase):
 *   emake failed
FireBurn commented 11 years ago

Hmm strange

It's definitely working here and changing the llvm-config in the ebuild as above will break things

It looks like our old favorite python 3 causing issues again :-(

Will look into it and push a fix

FireBurn commented 11 years ago

Well it doesn't break it - but it's not the issue

Fixed now and pushed to the overlay

Can you give it a spin?

FireBurn commented 11 years ago

Didn't mean to close until you confirm

jasnn commented 11 years ago

Confirming that this issue is fixed now. Thanks again Mike..

jasnn commented 11 years ago

I was looking at some of the other live ebuilds in the FireBurn and x11 overlays and it looked to me like python 2 can be specified using the PYTHON_COMPAT and python-single-r1.eclass and bumping it to EAPI=5, instead of using a patch like we previously solved it in this thread. So I just now tried an edited version of the dev-libs/libclc-9999 ebuild and it emerged cleanly. It is;

# Copyright 1999-2012 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

EAPI=5

EGIT_REPO_URI="git://people.freedesktop.org/~tstellar/${PN}"

if [[ ${PV} = 9999* ]]; then
        GIT_ECLASS="git-2"
        EXPERIMENTAL="true"
fi

PYTHON_COMPAT=( python{2_6,2_7} )

inherit base python-single-r1 $GIT_ECLASS

DESCRIPTION="OpenCL C library"
HOMEPAGE="http://libclc.llvm.org/"

if [[ $PV = 9999* ]]; then
        SRC_URI="${SRC_PATCHES}"
else
        SRC_URI=""
fi

LICENSE="MIT BSD"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE=""

RDEPEND="
        =sys-devel/clang-9999-r50[video_cards_radeon]
        =sys-devel/llvm-9999-r50[video_cards_radeon]"
DEPEND="${RDEPEND}"

src_configure() {
        ./configure.py \
                --with-llvm-config="${EPREFIX}/usr/bin/llvm-config" \
                --prefix="${EPREFIX}/usr"
}
FireBurn commented 11 years ago

I'm out the country again at the moment. Feel free to send me a merge request if you know how. Quite happy to apply this fix.

jasnn commented 11 years ago

Thanks Mike..

Unfortunately I'm a clueless noob, and I wouldn't have an idea how to generate the proper merge request. (I even tried googling an answer this morning, ended up creating my own fork of the repo, edited my fork locally, and then tried to push the simply changes back to my newly created fork, and couldn't figure out how, so I deleted my fork.)

It's not a big change, it doesn't affect anyone using the overlay now, and can certainly wait upon your return.

Jason

FireBurn commented 11 years ago

That's your ebuild now in the overlay - seems to work fine for me

jasnn commented 11 years ago

Thanks Mike,

Just so you know, I submitted a Gentoo bug report to make the same changes to the x11 overlay libclc-9999.ebuild.

Jason

FireBurn commented 11 years ago

Cheers

Whats the bug number? I really aught to report the radonsi thing too On 27 May 2013 20:35, "jasnn" notifications@github.com wrote:

Thanks Mike,

Just so you know, I submitted a Gentoo bug report to make the same changes to the x11 overlay libclc-9999.ebuild.

Jason

— Reply to this email directly or view it on GitHubhttps://github.com/FireBurn/Overlay/issues/12#issuecomment-18512029 .

jasnn commented 11 years ago

It's at https://bugs.gentoo.org/show_bug.cgi?id=470928

Jason