search

FireBurn / Overlay

Gentoo Overly
GNU General Public License v3.0
21 stars 6 forks source link

www-client/chromium-79.0.3928.4 failed to build #61

Closed hlukasz closed 5 years ago

hlukasz commented 5 years ago

I am unable to build chromium 79.0.3928.4 there is a following error (repeated in few places): ../../base/logging.h:590:32: error: variable ‘true_if_passed’ of non-literal type ‘logging::CheckOpResult’ in ‘constexpr’ function

Full build log here: build.log.gz

Any advice?

FireBurn commented 5 years ago

Are you using clang to build? - that's what I'm using here (clang 10 specificily)

I'm just about finished with my chromium-79.0.3941.4 ebuild which should hopefully be ready within a few hours

hlukasz commented 5 years ago

I have tested 79.0.3941.4, still without luck. The same error both in GCC and clang (but different than in my first post).

../../third_party/swiftshader/src/System/Linux/MemFd.hpp:25:11: error: expected identifier or '{'
namespace linux
          ^  
<built-in>:404:15: note: expanded from here  
#define linux 1

gcc version 9.1.0 (Gentoo 9.1.0-r1 p1.1) clang version 7.1.0 (tags/RELEASE_710/final)

Full logs here: build_clang.log.gz build_gcc.log.gz

FireBurn commented 5 years ago

I didn't get that with clang-10

But I did notice this commit to the upstream swiftshader:

https://github.com/google/swiftshader/commit/fb632b91110cabce297c34b8c01ec8c931a10933

Might be worth seeing if you can apply it

hlukasz commented 5 years ago

After applying that commit I was able to build it with clang-8, I didn't test with GCC. Thanks for support. I think it may be worth to add it to overlay.

FireBurn commented 5 years ago

Did you change that patch at all to get it to apply?

FireBurn commented 5 years ago

Ah just needed to update the paths

https://github.com/FireBurn/Overlay/commit/331f5e61d27234df824a431b0f3ecf52559df691