search

FireCubeStudios / Protecc

It protecc
https://apps.microsoft.com/store/detail/protecc-2fa-client/9PJX91M06TZS
MIT License
353 stars 42 forks source link

Adding more than 20 2FA accounts creates lots of issues. #29

Closed Kafman closed 1 year ago

Kafman commented 1 year ago

Hi,

If you add more than 20 different 2FA accounts, the apps behaves completely erratic.

For instance:

  1. It won't led you add a 21st account or more.
  2. Performance issues, memory leaks: image
  3. Closing and reopening the app with 20 accounts, will duplicate your existing 2FA accounts: image (Probably related to #14)
  4. Windows Hello sometimes will take a lof of time to ask for credentials.
FireCubeStudios commented 1 year ago
  1. Yes thats because credential locker only supports upto 20 entries.
  2. What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?
  3. This is being looked at
  4. How often does it take a long time to ask for credentials?
Kafman commented 1 year ago
  1. Yes thats because credential locker only supports upto 20 entries.
  2. What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?
  3. This is being looked at
  4. How often does it take a long time to ask for credentials?
  1. Would there be a possibility to support more than 20? Edit: I see that's a limitation from MS... goddamn, I love this app but I need something that supports more than 20 accounts...
  2. It is having the 20 accounts at the same time, as soon as I launch the app, I can see in Task Manager a CPU spike and memory usage increasing. I have removed 5 accounts and I can see that the memory usage is well and stable.
  3. Gotcha.
  4. With the 20 accounts, on first launch is almost instantly, if I closed it and launch it a second time, it can take between 15-20 seconds to show the Windows Hello window.
FireCubeStudios commented 1 year ago

  1. Yes thats because credential locker only supports upto 20 entries.

  2. What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?

  3. This is being looked at

  4. How often does it take a long time to ask for credentials?

  1. Would there be a possibility to support more than 20? Edit: I see that's a limitation from MS... goddamn, I love this app but I need something that supports more than 20 accounts...

  2. It is having the 20 accounts at the same time, as soon as I launch the app, I can see in Task Manager a CPU spike and memory usage increasing. I have removed 5 accounts and I can see that the memory usage is well and stable.

  3. Gotcha.

  4. With the 20 accounts, on first launch is almost instantly, if I closed it and launch it a second time, it can take between 15-20 seconds to show the Windows Hello window.

Hi for the 20 account limitation there is another version of Protecc that uses encrypted database instead of credential locker and will support 20+ accounts, syncing, groups and images due to no limitations however that one will probably be paid

  1. I see I believe it's because the animated text box control is heavy to use and isn't designed to have 20 instances. I will think about what I can do with this
  2. The reason the first launch is fast is because of the pre launch technique. I will add optimisation to make initial windows hello launch faster
FireCubeStudios commented 1 year ago

Alright so I have added it so that if there are more than 10 cards the subsequent cards wont have animation. Yes it is not ideal but it improves performance

FireCubeStudios commented 1 year ago

And I added a block to add more than 20 accounts + startup improvements. I think this should resolv the issues so I am closing this now