search

FireDiscordBot / bot

A Discord bot for all your needs. With memes, utilities, moderation & more, Fire is the only bot you'll need.
https://getfire.bot/
GNU Affero General Public License v3.0
400 stars 73 forks source link

Adding HEX8 to color.ts #121

Closed funwaa closed 3 years ago

funwaa commented 3 years ago

Adding 8-digit HEX string representation to fix issue #119

GamingGeek commented 3 years ago

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

funwaa commented 3 years ago

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

GamingGeek commented 3 years ago

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

HEX8 is just HEX with alpha. Decimal is the color represented as a numerical value. I've implemented it locally which you can see below image

funwaa commented 3 years ago

Thanks for the PR! After taking a more in-depth look at the change (a.k.a more than 2 seconds) it does not seem that this change is what Arthurism wanted in their issue but it's a good addition nonetheless.

Hm, I'm not quite sure what they meant with their issue. Do you understand and can you explain it better?

HEX8 is just HEX with alpha. Decimal is the color represented as a numerical value. I've implemented it locally which you can see below image

Oh I see. Using ${parseInt(color.toHex(), 16)} would've worked aswell, right?

GamingGeek commented 3 years ago

Oh I see. Using ${parseInt(color.toHex(), 16)} would've worked aswell, right?

Indeed it would, didn't think of using that :joy:

That's probably a better method than what I've done so I'll change it to that