search

FireDiscordBot / bot

A Discord bot for all your needs. With memes, utilities, moderation & more, Fire is the only bot you'll need.
https://getfire.bot/
GNU Affero General Public License v3.0
400 stars 73 forks source link

[SUGGESTION] Improve Error Messages #70

Closed Lisenaaaa closed 3 years ago

Lisenaaaa commented 3 years ago

Is your feature request related to a problem? Please describe. fire's error messages aren't the best tbh

Describe the solution you'd like image if the user isn't on the server, make it say something like "That user isn't on the server!"

Describe alternatives you've considered uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

Additional context

GamingGeek commented 3 years ago

the way commands that require a member work doesn't allow me to tell if it's a valid user or not, it just returns null so I can't make it say something like "That user isn't on the server!"

also please set a title before opening an issue and don't just spam "uhhhhhhhhhhh" in the alternatives section

Lisenaaaa commented 3 years ago

huh, makes sense

also my brain stops functioning properly later in the day so if im stupid then thats why

couldn't you check if they are on the server, before doing any of the mute code?

GamingGeek commented 3 years ago

it just returns null

https://github.com/FireDiscordBot/bot/blob/master/src/commands/Moderation/mute.ts#L39