search

FireDynamics / fdsreader

Python reader for FDS data
GNU General Public License v3.0
44 stars 18 forks source link

Error loading FDS Simulation: "object has no attribute 'particles'" #44

Closed TristanHehnen closed 1 year ago

TristanHehnen commented 1 year ago

Hi,

I get an error reading FDS simulations with fdsreader version 1.8.4: "AttributeError: 'Simulation' object has no attribute 'particles'" for line https://github.com/FireDynamics/fdsreader/blob/856cb3285fdabde062c24a23d1fb4ad52fc6504f/fdsreader/simulation.py#L203

Should it be self._particles instead of self.particles?

Edit: Forgot to say that in the simulation there are no particles.

Best, Tristan

JanVogelsang commented 1 year ago

Will have a look

JanVogelsang commented 1 year ago

@TristanHehnen Are you sure that there are no particles in the simulation? The fdsreader does definitely find something related to particles, which is why it goes into that line. Could you send me the fds-file?

JanVogelsang commented 1 year ago

Probiere es mal mit 1.8.5, Fehler ist gefixt.

TristanHehnen commented 1 year ago

Thank you very much!

Unfortunately, it now complains about the next thing...

It's line 112 in Simulation.py and it can't find meshes: "AttributeError: 'Simulation' object has no attribute '_meshes'"

Could this be related to different FDS versions? This file I'm using is for a somewhat older version.

JanVogelsang commented 1 year ago

This could very well be caused by an old FDS version, yes, as the SmokeView-File changed a lot during the years. The Fdsreader does only safely support FDS >= 6.7.5. Either run the simulation again with a newer FDS version or send me the old .smv file, so I can check if I can identify the problem with that version and maybe also (partly) support that version then.

JanVogelsang commented 1 year ago

Fixed in 1.8.6

TristanHehnen commented 1 year ago

Alright, works now, thank you very much!